Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add debugger manual #5265

Merged
merged 6 commits into from
May 13, 2020
Merged

docs: add debugger manual #5265

merged 6 commits into from
May 13, 2020

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju requested a review from ry May 13, 2020 11:45
lucacasonato
lucacasonato approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ry
ry approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry
Copy link
Member

ry commented May 13, 2020

Will these images be displayed if viewing markdown on github?

@bartlomieju
Copy link
Member Author

Will these images be displayed if viewing markdown on github?

They should, I used GH's markdown syntax

@bartlomieju bartlomieju merged commit e9ce043 into denoland:master May 13, 2020
@bartlomieju bartlomieju deleted the debugger_docs branch May 13, 2020 15:55
@bartlomieju
Copy link
Member Author

Images are visible on GitHub: https://github.com/denoland/deno/blob/master/docs/tools/debugger.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bartlomieju @ry @lucacasonato