Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Expose ErrorEvent globally #5222

Merged
merged 2 commits into from
May 11, 2020
Merged

fix: Expose ErrorEvent globally #5222

merged 2 commits into from
May 11, 2020

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented May 11, 2020

Fixes #5221

This PR exposes ErrorEvent globally, which is already in line with what the type definitions were saying.

bartlomieju
bartlomieju approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kitsonk

@bartlomieju bartlomieju merged commit d16c739 into denoland:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ErrorEvent should be exposed globally, not just workers
2 participants
@kitsonk @bartlomieju