fix(cli/js/net): default listen options changed to 0.0.0.0 from 127.0.0.1, #5144

[itspa1]

changed default from 127.0.0.1 to 0.0.0.0 in cli/js/net, closes #5144

[CLAassistant]

All committers have signed the CLA.

[shortdiv]

Hey, thanks for the PR!

I was planning on putting a PR in for this one as I'd noted in the issue. In general if you plan on doing work for an issue, please comment in the issue and notify folks before doing so. This makes it clear to everyone that an issue is being worked on, so nobody steps on other's toes. In the future, please refer to the contributing guidelines for best practices

[itspa1]

Hey, @shortdiv sorry, this was my first PR and tried to cover most of the guidelines, turns out I did miss one. Sorry again for that and I'll keep that in mind.

[shortdiv]

No matter, we're both working towards the same cause!

Congrats on your first PR! 💪

[itspa1]

yea, that is all that matters, working towards the same cause.
Thanks for that!

[bartlomieju]

@ry we need to decide on this PR before Wednesday. Personally I prefer 127.0.0.1 as default - binding to 0.0.0.0 should be explicit.

[itspa1]

@bartlomieju even I prefer the default fallback to be 127.0.0.1 cause it seems more secure. The functionality of Node.Js tho is that it falls back to 0.0.0.0, and I think most people would assume that to be the case. And also the comment in the code seems to point towards the case that default it would fall back to 0.0.0.0

[ry]

LGTM