Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli/installer): Fix concurrent env handling in tests #5182

Merged
merged 1 commit into from
May 9, 2020
Merged

fix(cli/installer): Fix concurrent env handling in tests #5182

merged 1 commit into from
May 9, 2020

Conversation

nayeemrmn
Copy link
Collaborator

Fixes #5178.

bartlomieju
bartlomieju approved these changes May 9, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @nayeemrmn

@bartlomieju bartlomieju merged commit 7a635ed into denoland:master May 9, 2020
@nayeemrmn nayeemrmn deleted the installer-test-race branch May 9, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test installer::tests::install_basic is flaky
2 participants
@nayeemrmn @bartlomieju