Add support for X-Deno-Warning header

[ry]

No description provided.

[lucacasonato]

We should have docs about this header.

[ry]

@lucacasonato ok docs added

[kitsonk]

LGTM... Good idea! Wish I had thought of it... 😊

[ry]

@bartlomieju This would be better in the file_fetcher module, but I couldn't find any place that actually worked for displaying the message. Hence http_util. I figure this can be moved at a later point. Or if you know a better place to put it now we can move it...

[bartlomieju]

@bartlomieju This would be better in the file_fetcher module, but I couldn't find any place that actually worked for displaying the message. Hence http_util. I figure this can be moved at a later point. Or if you know a better place to put it now we can move it...

I agree I can move it at later time.

We should have docs about this header.

In my opinion this header shouldn't be documented or considered public. I can think of many usages of this header to display unwanted info (just like stuff displayed during npm install).

LGTM, but I want to once again express my dislike for this solution and propose to remove untagged imports from deno.land/std/ (instead use deno.land/std@master or deno.land/[email protected]).

[lucacasonato]

LGTM, but I want to once again express my dislike for this solution and propose to remove untagged imports from deno.land/std/ (instead use deno.land/std@master or deno.land/[email protected]).

Ref denoland/dotland#250

[ry]

In my opinion this header shouldn't be documented or considered public. I can think of many usages of this header to display unwanted info (just like stuff displayed during npm install).

I'm not so worried about registry spam - but I changed my mind and agree it should be undocumented. This isn't something we necessarily want to support forever - let's just keep it an internal feature until some future date.

LGTM, but I want to once again express my dislike for this solution and propose to remove untagged imports from deno.land/std/ (instead use deno.land/std@master or deno.land/[email protected]).

Noted. Let's discuss in a couple weeks when the dust has settled. I predict the number of incompatibility complaints drops to zero.

[nayeemrmn]

I'm not so worried about registry spam - but I changed my mind and agree it should be undocumented. This isn't something we necessarily want to support forever - let's just keep it an internal feature until some future date.

I infer that this is being added just to warn people against linking to master for deno.land. In response to a security concern, I once suggested this feature as a way for publishers to warn users of vulnerabilities that can be updated against. I think some kind of channel for this is important.