fix: crypto is not accessible in a Worker scope #5121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oops, |
sunsetkookaburra
changed the title
bartlomieju
reviewed
May 7, 2020
cli/tests/039_worker_deno_ns.ts
Outdated
Comment on lines
1
to
4
| const w1 = new Worker("./039_worker_deno_ns/has_ns.ts", { | ||
| type: "module", | ||
| deno: true, | ||
| }); |
There was a problem hiding this comment.
Revert; these files are being removed in #5128; please add a test case to cli/tests/worker_test.ts
bartlomieju
reviewed
May 7, 2020
|
@bartlomieju Do I need to squash the commits into one, or will the PR put them into a single commit? |
That's not needed, we'll squash them when merging |
sunsetkookaburra
changed the title
|
this should be ready now |
bartlomieju
approved these changes
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5111
move
cryptoto globals/sharedGlobals