Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING: make Deno.hostname unstable #5108

Merged
merged 5 commits into from
May 9, 2020
Merged

BREAKING: make Deno.hostname unstable #5108

merged 5 commits into from
May 9, 2020

Conversation

ry
Copy link
Member

@ry ry commented May 6, 2020

No description provided.

@ry ry requested a review from bartlomieju May 6, 2020 18:45
bartlomieju
bartlomieju reviewed May 6, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where's check in Rust?

@ry
Copy link
Member Author

ry commented May 9, 2020

Need to get this landed before RC2

@ry ry merged commit b8364a2 into denoland:master May 9, 2020
@ry ry deleted the hostname branch May 9, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ry @bartlomieju