-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING: refactor(std): Prepend underscores to private modules #5087
Conversation
@nayeemrmn |
@ry Please review. |
It would be a misuse of Deno.iter()'s result.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - sorry for the delay @nayeemrmn - Bartek Bert and I had a discussion yesterday about std and stability. We decided to decouple the version from cli and not make stability guarantees yet (#5158). That discussion was holding up landing this patch.
@ry @nayeemrmn I found some files were made underscored on this PR. What does it mean? About |
underscore means the module should be considered private I think http/io.ts was erroneously marked as private, we can make it public again. |
Yes. There's no way of making them not downloadable which is why we use the underscore convention to indicate that the exports aren't stable / can be restructured by us at will -- so shouldn't be imported directly.
The exports of that module have no rhyme or reason at the moment and are definitely tailored to internal usage. For example, If anyone is interested, they can make a public |
@nayeemrmn I agree that current I think |
* Prepend underscores to private modules * Remove collectUint8Arrays() It would be a misuse of Deno.iter()'s result. * Move std/_util/async.ts to std/async * Move std/util/sha*.ts to std/hash
* Prepend underscores to private modules * Remove collectUint8Arrays() It would be a misuse of Deno.iter()'s result. * Move _util/async.ts to async * Move util/sha*.ts to hash
* Prepend underscores to private modules * Remove collectUint8Arrays() It would be a misuse of Deno.iter()'s result. * Move _util/async.ts to async * Move util/sha*.ts to hash
* Prepend underscores to private modules * Remove collectUint8Arrays() It would be a misuse of Deno.iter()'s result. * Move _util/async.ts to async * Move util/sha*.ts to hash
* Prepend underscores to private modules * Remove collectUint8Arrays() It would be a misuse of Deno.iter()'s result. * Move _util/async.ts to async * Move util/sha*.ts to hash
* Prepend underscores to private modules * Remove collectUint8Arrays() It would be a misuse of Deno.iter()'s result. * Move _util/async.ts to async * Move util/sha*.ts to hash
* Prepend underscores to private modules * Remove collectUint8Arrays() It would be a misuse of Deno.iter()'s result. * Move _util/async.ts to async * Move util/sha*.ts to hash
* Prepend underscores to private modules * Remove collectUint8Arrays() It would be a misuse of Deno.iter()'s result. * Move _util/async.ts to async * Move util/sha*.ts to hash
* Prepend underscores to private modules * Remove collectUint8Arrays() It would be a misuse of Deno.iter()'s result. * Move _util/async.ts to async * Move util/sha*.ts to hash
std/util/async.ts
tostd/async/*.ts
.std/util/sha*.ts
tostd/hash/sha*.ts
.std/examples
.isWindows
andEOL
fromstd/path
. They don't belong there and shouldn't really require a dependency.collectUint8Arrays()
fromstd/util/async.ts
. It would be a misuse ofDeno.iter()
's result.