Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inspector hanging when task budget is exceeded #5083

Merged
merged 1 commit into from
May 5, 2020
Merged

Fix inspector hanging when task budget is exceeded #5083

merged 1 commit into from
May 5, 2020

Conversation

piscisaureus
Copy link
Member

The issue is solved by proxying websocket messages over a pair of
futures::mpsc::unbounded channels. As these are are implemented in
the 'futures' crate, they can't participate in Tokio's cooperative
task yielding.

@piscisaureus piscisaureus changed the title Fix inspector hanging when task budget is exceeded (#5039) Fix inspector hanging when task budget is exceeded May 5, 2020
@piscisaureus piscisaureus mentioned this pull request May 5, 2020
Closed
piscisaureus added a commit to piscisaureus/deno that referenced this pull request May 5, 2020
@piscisaureus
Fix inspector hanging when task budget is exceeded (denoland#5083)
00cdc08 
The issue is solved by proxying websocket messages over a pair of
`futures::mpsc::unbounded` channels. As these are are implemented in
the 'futures' crate, they can't participate in Tokio's cooperative
task yielding.
piscisaureus added a commit to piscisaureus/deno that referenced this pull request May 5, 2020
@piscisaureus
Fix inspector hanging when task budget is exceeded (denoland#5083)
7e0d9ce 
The issue is solved by proxying websocket messages over a pair of
`futures::mpsc::unbounded` channels. As these are are implemented in
the 'futures' crate, they can't participate in Tokio's cooperative
task yielding.
piscisaureus added a commit to piscisaureus/deno that referenced this pull request May 5, 2020
@piscisaureus
Fix inspector hanging when task budget is exceeded (denoland#5083)
2be580b 
The issue is solved by proxying websocket messages over a pair of
`futures::mpsc::unbounded` channels. As these are are implemented in
the 'futures' crate, they can't participate in Tokio's cooperative
task yielding.
piscisaureus added a commit to piscisaureus/deno that referenced this pull request May 5, 2020
@piscisaureus
Fix inspector hanging when task budget is exceeded (denoland#5083)
6f9fad5 
The issue is solved by proxying websocket messages over a pair of
`futures::mpsc::unbounded` channels. As these are are implemented in
the 'futures' crate, they can't participate in Tokio's cooperative
task yielding.
piscisaureus added a commit to piscisaureus/deno that referenced this pull request May 5, 2020
@piscisaureus
Fix inspector hanging when task budget is exceeded (denoland#5083)
44034a1 
The issue is solved by proxying websocket messages over a pair of
`futures::mpsc::unbounded` channels. As these are are implemented in
the 'futures' crate, they can't participate in Tokio's cooperative
task yielding.
piscisaureus added a commit to piscisaureus/deno that referenced this pull request May 5, 2020
@piscisaureus
Fix inspector hanging when task budget is exceeded (denoland#5083)
380c2a0 
The issue is solved by proxying websocket messages over a pair of
`futures::mpsc::unbounded` channels. As these are are implemented in
the 'futures' crate, they can't participate in Tokio's cooperative
task yielding.
piscisaureus added a commit to piscisaureus/deno that referenced this pull request May 5, 2020
@piscisaureus
Fix inspector hanging when task budget is exceeded (denoland#5083)
4a09b5d 
The issue is solved by proxying websocket messages over a pair of
`futures::mpsc::unbounded` channels. As these are are implemented in
the 'futures' crate, they can't participate in Tokio's cooperative
task yielding.
piscisaureus added a commit to piscisaureus/deno that referenced this pull request May 5, 2020
@piscisaureus
Fix inspector hanging when task budget is exceeded (denoland#5083)
d59547f 
The issue is solved by proxying websocket messages over a pair of
`futures::mpsc::unbounded` channels. As these are are implemented in
the 'futures' crate, they can't participate in Tokio's cooperative
task yielding.
@piscisaureus piscisaureus requested a review from ry May 5, 2020 06:38
piscisaureus added a commit to piscisaureus/deno that referenced this pull request May 5, 2020
@piscisaureus
Fix inspector hanging when task budget is exceeded (denoland#5083)
bcd7301 
The issue is solved by proxying websocket messages over a pair of
`futures::mpsc::unbounded` channels. As these are are implemented in
the 'futures' crate, they can't participate in Tokio's cooperative
task yielding.
piscisaureus added a commit to piscisaureus/deno that referenced this pull request May 5, 2020
@piscisaureus
Fix inspector hanging when task budget is exceeded (denoland#5083)
613d467 
The issue is solved by proxying websocket messages over a pair of
`futures::mpsc::unbounded` channels. As these are are implemented in
the 'futures' crate, they can't participate in Tokio's cooperative
task yielding.
piscisaureus added a commit to piscisaureus/deno that referenced this pull request May 5, 2020
@piscisaureus
Fix inspector hanging when task budget is exceeded (denoland#5083)
374d5e7 
The issue is solved by proxying websocket messages over a pair of
`futures::mpsc::unbounded` channels. As these are are implemented in
the 'futures' crate, they can't participate in Tokio's cooperative
task yielding.
ry
ry reviewed May 5, 2020
View reviewed changes
cli/tests/integration_tests.rs Outdated
let script = deno::test_util::root_path()
.join("cli")
.join("tests")
.join("inspector3.js");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's also deno::test_util::tests_path()

ry
ry reviewed May 5, 2020
View reviewed changes
cli/tests/integration_tests.rs
let s = r#"{"method":"Debugger.paused","#;
assert!(socket_rx.next().await.unwrap().starts_with(s));
// Send the 'Debugger.resume' request.
let s = format!(r#"{{"id":{},"method":"Debugger.resume"}}"#, request_id);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ry
ry approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice test, I confirmed it hangs on master.

piscisaureus added a commit to piscisaureus/deno that referenced this pull request May 5, 2020
@piscisaureus
Fix inspector hanging when task budget is exceeded (denoland#5083)
37fd13f 
The issue is solved by proxying websocket messages over a pair of
`futures::mpsc::unbounded` channels. As these are are implemented in
the 'futures' crate, they can't participate in Tokio's cooperative
task yielding.
@piscisaureus
Fix inspector hanging when task budget is exceeded (denoland#5083)
e574437 
The issue is solved by proxying websocket messages over a pair of
`futures::mpsc::unbounded` channels. As these are are implemented in
the 'futures' crate, they can't participate in Tokio's cooperative
task yielding.
@piscisaureus piscisaureus merged commit e574437 into denoland:master May 5, 2020
@piscisaureus piscisaureus deleted the fix_inspector branch May 5, 2020 14:37
SASUKE40 pushed a commit to SASUKE40/deno that referenced this pull request May 7, 2020
@piscisaureus @SASUKE40
Fix inspector hanging when task budget is exceeded (denoland#5083)
1900818 
The issue is solved by proxying websocket messages over a pair of
`futures::mpsc::unbounded` channels. As these are are implemented in
the 'futures' crate, they can't participate in Tokio's cooperative
task yielding.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piscisaureus @ry