feat: Add WritableStreams (and enable ReadableStreams piping) #4980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
approved these changes
Apr 30, 2020
There was a problem hiding this comment.
Rubber stamp LGTM - thanks for working on this @kitsonk
I can't help but wonder why the streams spec is so much more complex than Deno's Reader/Writer/Buffer concepts. It seems to be this wild unconstrained orgy of algorithms and objects - to accomplish ideas that were seemingly worked out 30 years ago with unix pipes. I can only conclude that I'm missing some core idea - Deno can generically stream data (say from a TCP socket to a file) with about 200 lines of javascript for all the code involved....
SASUKE40
pushed a commit
to SASUKE40/deno
that referenced
this pull request
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds WritableStreams and enables the
ReadableStream.prototype.pipeThroughandReadableStream.prototype.pipeTowhich required WritableStreams.(Does a minimal implementation of #4918 to support not swallowing internal errors)