Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deno doc handles default exports #4873

Merged
merged 5 commits into from
May 6, 2020

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Apr 23, 2020

This PR updates deno doc so default exports are handled.

Currently only variable/function/class exports are supported
and they would show up as "default" in the doc page.

We still need to add support for expressions that are default exports:

export default {
  foo,
  bar,
}

Unfortunately it requires to change Node structure.

@bartlomieju bartlomieju changed the title [WIP] feat: deno doc handles default exports feat: deno doc handles default exports May 6, 2020
@bartlomieju bartlomieju requested a review from ry May 6, 2020 10:58
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. LGTM

@bartlomieju bartlomieju merged commit e18aaf4 into denoland:master May 6, 2020
@bartlomieju bartlomieju deleted the deno_doc_exports branch May 6, 2020 12:48
mzdunek93 pushed a commit to mzdunek93/deno that referenced this pull request May 6, 2020
SASUKE40 pushed a commit to SASUKE40/deno that referenced this pull request May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants