Rewrite streams #4842
Merged
Rewrite streams #4842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
approved these changes
Apr 22, 2020
There was a problem hiding this comment.
This is a big patch, I can't really review all of it. I view it as upgrading a dependency from sd-streams to Kitson's own streams written with Deno in mind - which is obviously preferable : ) In any case it's a lot less code, so that's good.
I'm slowly working on a rewrite to fetch, so I think I'll be interacting with this code in the near future.
LGTM. Thank you @kitsonk!
SASUKE40
pushed a commit
to SASUKE40/deno
that referenced
this pull request
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites streams "from scratch" following patterns we wish to maintain in Deno. It is strongly aligned to the specification.
Currently it supports
ReadableStreamincludingReadableByteStreamControllerbut does not supportReadableStreamBYOBReaderorWritableStream(and associatedReadableStreamAPIs that require a writable stream). This brings it parity with what was in streams before.I've addressed a couple issues with our
fetch()implementation that are not fully optimal, but significantly more work needs to be done there to clean that up properly.