Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store debugger url on DenoInspector #4793

Merged
merged 4 commits into from
Apr 18, 2020
Merged

store debugger url on DenoInspector #4793

merged 4 commits into from
Apr 18, 2020

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Apr 17, 2020 •
edited
Loading

Closes #4780

This PR stores InspectorInfo on Worker. That way it's possible to get inspector URL for certain worker programatically.

Prerequisite for test coverage

@bartlomieju bartlomieju changed the title store InspectorInfo on Worker store InspectorInfo on DenoInspector Apr 17, 2020
piscisaureus
piscisaureus reviewed Apr 17, 2020
View reviewed changes
cli/inspector.rs Outdated Show resolved Hide resolved
@bartlomieju bartlomieju changed the title store InspectorInfo on DenoInspector store debugger url on DenoInspector Apr 17, 2020
piscisaureus
piscisaureus approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better!
One thing, won't be able to access the URL now because it's a private field -- so you will eventually need to add a getter too.
But that can wait. LGTM

@bartlomieju bartlomieju merged commit 10469ec into denoland:master Apr 18, 2020
@bartlomieju bartlomieju deleted the worker_inspector_info branch April 18, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piscisaureus piscisaureus piscisaureus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose inspector URL for Worker
2 participants
@bartlomieju @piscisaureus