Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Implement window.fetch #478

Closed
wants to merge 5 commits into from
Closed

Conversation

thgh
Copy link
Contributor

@thgh thgh commented Aug 7, 2018

I commented src/handlers.rs#L183 to keep it compiling. Otherwise I typically get these errors:

error[E0373]: closure may outlive the current function, but it borrows `id`, which is owned by the current function
   --> ../../src/handlers.rs:182:10
    |
182 |     .map(|res| {
    |          ^^^^^ may outlive borrowed value `id`
error[E0277]: `*const binding::DenoC` cannot be shared between threads safely
   --> ../../src/handlers.rs:168:3
    |
168 |   rt::run(req);
    |   ^^^^^^^ `*const binding::DenoC` cannot be shared between threads safely

@ry ry force-pushed the tokio_timers branch 2 times, most recently from 8551164 to 1fcc498 Compare August 9, 2018 04:11
@ry
Copy link
Member

ry commented Aug 9, 2018

Sorry for the delay in reviewing! I will get to this soon - we're almost caught up.

@ry
Copy link
Member

ry commented Aug 13, 2018

Thanks @thgh ! I'm continuing to work on this in #512 where i've rebased your commits. Closing this one.

@ry ry closed this Aug 13, 2018
hardfist pushed a commit to hardfist/deno that referenced this pull request Aug 7, 2024
Bumped versions for 0.252.0

Please ensure:
- [ ] Crate versions are bumped correctly
To make edits to this PR:
```shell
git fetch upstream release_0_252.0 && git checkout -b release_0_252.0 upstream/release_0_252.0
```

cc @mmastrac

Co-authored-by: mmastrac <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants