Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deno doc parses super-class names #4595

Merged
merged 4 commits into from
Apr 3, 2020
Merged

deno doc parses super-class names #4595

merged 4 commits into from
Apr 3, 2020

Conversation

ondras
Copy link
Contributor

@ondras ondras commented Apr 2, 2020

Well.

This is my noobish attempt at making deno doc parse the extends clause of a class definition. Incidentally, it is also my very first rust code ever written. Still no idea how the Box stuff is supposed to function.

It seems to work and I also added a test for the feature.

lucacasonato
lucacasonato reviewed Apr 2, 2020
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :-D

Your test doesn't cover the printing part yet. Could you add a check to the bottom of that test to test that the output of the printer includes class Foobar extends Fizz?

cli/doc/printer.rs Outdated Show resolved Hide resolved
@ry ry requested a review from bartlomieju April 2, 2020 23:38
@ondras @lucacasonato
refactored to if let
4c1db21 
Co-Authored-By: Luca Casonato <[email protected]>
@ondras
Copy link
Contributor Author

ondras commented Apr 3, 2020

Looks good :-D

Great, thanks ;)

Could you add a check to the bottom of that test to test that the output of the printer includes class Foobar extends Fizz?

Yes, will add.

@ondras
Copy link
Contributor Author

ondras commented Apr 3, 2020

Test added.

bartlomieju
bartlomieju approved these changes Apr 3, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ondras

@bartlomieju bartlomieju merged commit b57d075 into denoland:master Apr 3, 2020
@ondras
Copy link
Contributor Author

ondras commented Apr 3, 2020

Great! @bartlomieju , shall I continue with exposing implements as well?

@ondras ondras deleted the doc-parse-extends branch April 3, 2020 08:40
@bartlomieju
Copy link
Member

Great! @bartlomieju , shall I continue with exposing implements as well?

@ondras sure

@ondras ondras mentioned this pull request Apr 3, 2020
Merged
@ondras
Copy link
Contributor Author

ondras commented Apr 3, 2020

Great! @bartlomieju , shall I continue with exposing implements as well?

@ondras sure

Continuing in #4604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato left review comments

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ondras @bartlomieju @lucacasonato