Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove /std/media_types #4594

Merged
merged 4 commits into from
Apr 3, 2020
Merged

Remove /std/media_types #4594

merged 4 commits into from
Apr 3, 2020

Conversation

ry
Copy link
Member

@ry ry commented Apr 2, 2020

Fix #4292

@ry ry mentioned this pull request Apr 2, 2020
@kitsonk
Copy link
Contributor

kitsonk commented Apr 2, 2020

I will create another repo today and raise a PR for denoland/x.

Just a thought, std/http/file_server.ts is really just an example. It doesn't export anything and it really isn't that super useful on its own. It isn't a library, as it doesn't export anything. Maybe we should earmark that a bit better its intent.

@kitsonk
Copy link
Contributor

kitsonk commented Apr 2, 2020

Moved it to oakserver and created a PR here: denoland/dotland#299

std/http/file_server.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry requested a review from bartlomieju April 3, 2020 16:07
@ry ry merged commit 13db64f into denoland:master Apr 3, 2020
@ry
Copy link
Member Author

ry commented Apr 3, 2020

Moved to https://deno.land/x/media_types/

@ry ry deleted the rm-media-types branch April 3, 2020 16:13
".json": "application/json",
".map": "application/json",
".txt": "text/plain",
".ts": "application/typescript",
Copy link
Contributor

@zhmushan zhmushan Apr 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ry I just tried it and found that using application/typescript, the browser will download the file directly, I think that .ts should be mapped to application/javascript or text/typescript

caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

media_types API is not good
4 participants