Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose global state publicly #4572

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Conversation

mraerino
Copy link
Contributor

@mraerino mraerino commented Apr 1, 2020

In order to be able to use the deno crate in other programs, one should be able to run stuff like the TsCompiler, which is exposed, but needs a GlobalState object in some function signatures.

This change would enable that usage.

An alternative would be to just expose the GlobalState struct instead of the full module.

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 2ff8012 into denoland:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants