-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std(media_types): change .ts content type to application/typescript #4563
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Since we're forking the database, can you please rename the file std/media_types/db_c50e0d1.json
to std/media_types/db.json
?
I don't think this database should be modified directly. What if the standard change in the future and we need to update the database using automated script without having our custom patch (typescript in this case) erased? Beside, this is not standard complaint, nor is it useful for all cases. Instead, I think you should leave the database alone and create another database (let's call it |
|
I don't think it's such a big deal to fork the database... any changes to the database at this point are going to be very minor - I think we would be able to handle maintaining it. @KSXGitHub your solution is a clean way to overlay changes on top of the existing database... but maybe it's less cognitive overhead to just fork. |
@zhmushan Let me re-iterate my points:
|
Forking would duplicate the amount of data. On the other hand, making a specialized database is very lightweight: It contains only TypeScript and JavaScript. |
@KSXGitHub By "forking" I mean that we would never again pull updates from the origin. cc @kitsonk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm fine with it. There is no official source for media types. Even this source db is a conglomeration of different sources. I think it is fine to maintain wholly seperate. Git history can serve as our record of differences. If we ever wanted to update from the source again, we would just apply a git diff. |
follow #4555