Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid blob type #4536

Merged
merged 3 commits into from
Mar 31, 2020
Merged

Fix invalid blob type #4536

merged 3 commits into from
Mar 31, 2020

Conversation

crowlKats
Copy link
Member

Fixes #2302

ry
ry reviewed Mar 31, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you think you could add a little test to cli/js/tests/blob_test.ts ?

@crowlKats
Copy link
Member Author

sure

ry
ry approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@ry ry merged commit 7b675a3 into denoland:master Mar 31, 2020
@crowlKats crowlKats deleted the no_blob_invalid_type_throw branch March 31, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

blob slice should not throw
2 participants
@crowlKats @ry