Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: Add common to std/path #4527

Merged
merged 1 commit into from
Mar 30, 2020
Merged

std: Add common to std/path #4527

merged 1 commit into from
Mar 30, 2020

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Mar 30, 2020

This PR add a utility that I have had to use before in the bundler to std/path but wanted to use it elsewhere, where the common path can be determined for a given set of paths.

For example:

import { common } from "https://deno.land/std/path/mod.ts";

const p = common(
  [
    "./deno/cli/js/deno.ts",
    "./deno/std/path/mod.ts",
    "./deno/cli/js/main.ts"
  ],
  "/"
);
console.log(p); // ./deno/

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 7670a13 into denoland:master Mar 30, 2020
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants