console: print promise details #4524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitsonk
reviewed
Mar 29, 2020
cli/js/globals.ts
Outdated
| @@ -102,6 +102,8 @@ declare global { | |||
|
|
|||
| formatError: (e: Error) => string; | |||
|
|
|||
| getPromiseDetails(promise: Promise<unknown>) : [number, unknown]; | |||
There was a problem hiding this comment.
This should be typed a lot more specifically. If the second argument of the tuple is the value of the promise, then:
Suggested change
| getPromiseDetails(promise: Promise<unknown>) : [number, unknown]; | |
| getPromiseDetails<T>(promise: Promise<T>) : [number, T]; |
Also provide some JSDoc please, so this is easily documented.
core/bindings.rs
Outdated
| res.set( | ||
| context, | ||
| v8::Integer::new(scope, 0).into(), | ||
| promise.result(scope).into(), |
There was a problem hiding this comment.
run cargo clippy to pick up these linting errors.
core/bindings.rs
Outdated
| mut rv: v8::ReturnValue, | ||
| ) { | ||
| if !args.get(0).is_promise() { | ||
| return; |
There was a problem hiding this comment.
I'm not sure how this code is going to behave at runtime with this. It shouldn't silently fail. We should effectively raise a JS error with appropriate information, like a TypeError.
There was a problem hiding this comment.
It returned undefined in that way; however I like the idea of throwing TypeError more.
mhvsa
force-pushed
the
print_promises
branch
2 times, most recently
from
decb086
to
80df495
Compare
mhvsa
changed the title
|
Review Ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with #3165
Current:
Target: