Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Fix some typos and improve a few sentences in the std manual #4522

Merged
merged 2 commits into from
Mar 30, 2020

Conversation

NiklasEi
Copy link
Contributor

While reading through large parts of the file I corrected a few typos.

@CLAassistant
Copy link

CLAassistant commented Mar 29, 2020

CLA assistant check
All committers have signed the CLA.

@NiklasEi NiklasEi changed the title Fix some typos and improve a few sentences in the std manual doc: Fix some typos and improve a few sentences in the std manual Mar 29, 2020
std/manual.md Outdated
Comment on lines 1136 to 1137
map, of what the source file name was. The second argument are optional
`options` of the type `Deno.CompilerOptions`. The function resolves with a map
Copy link
Collaborator

@nayeemrmn nayeemrmn Mar 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subject verb agreement? (maybe "contains" instead of "are")

std/manual.md Outdated
Comment on lines 1641 to 1638
global/`window` namespace should have JSDoc documentation. This documentation is
global `window` namespace should have JSDoc documentation. This documentation is
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was fine I think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok I might have misunderstood that one. I'll revert it.

Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Even if English is my first language, I don't always write well!

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ry ry merged commit 92f1c71 into denoland:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants