Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check to fail the benchmark test on server error #4519

Merged
merged 3 commits into from
Mar 30, 2020
Merged

Add check to fail the benchmark test on server error #4519

merged 3 commits into from
Mar 30, 2020

Conversation

avillega
Copy link
Contributor

Closes #4187

@CLAassistant
Copy link

CLAassistant commented Mar 28, 2020 •
edited
Loading

CLA assistant check)
All committers have signed the CLA.

@ry ry marked this pull request as ready for review March 30, 2020 18:04
ry
ry approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @avillega - LGTM

@ry ry merged commit 3892d49 into denoland:master Mar 30, 2020
@avillega avillega deleted the fix_benchamarks_not_failing branch March 31, 2020 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in benchmarked code should fail benchmark CI
3 participants
@avillega @CLAassistant @ry