Update to Prettier 2 and use ES Private Fields #4498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
bartlomieju
reviewed
Mar 28, 2020
|
@kitsonk Thanks for doing this! |
dubiousjim
added a commit
to dubiousjim/deno
that referenced
this pull request
Mar 29, 2020
* denoland/master: (35 commits) Ignore flaky test cafile_info (denoland#4517) fix(inspector): proper error message on port collision (denoland#4514) feat: Added colors to doc output (denoland#4518) v0.38.0 feat: Add "deno doc" subcommand (denoland#4500) Update to Prettier 2 and use ES Private Fields (denoland#4498) upgrade: dprint 0.9.6 (denoland#4509) upgrade: rusty_v8 to v0.3.9 (denoland#4505) feat: Support Inspector / Chrome Devtools (denoland#4484) Improve isatty and kill API docs; Deno.kill() - throw on Windows (denoland#4497) refactor: rename ConsoleOptions to InspectOptions (denoland#4493) upgrade: dprint 0.9.5 (denoland#4491) feat: window.close() (denoland#4474) errors: replace .lines with explicit .split newline (denoland#4483) doc: improve various API docs and include examples (denoland#4486) hide source line if error message longer than 150 chars (denoland#4487) fix: add fsEvent notify::Error casts (denoland#4488) feat: add queueMicrotask to d.ts (denoland#4477) Revert "avoid using same port number for test (denoland#4147)" docs: update manual about how to run tests for std (denoland#4462) ...
dubiousjim
added a commit
to dubiousjim/deno
that referenced
this pull request
Mar 29, 2020
* denoland/master: Ignore flaky test cafile_info (denoland#4517) fix(inspector): proper error message on port collision (denoland#4514) feat: Added colors to doc output (denoland#4518) v0.38.0 feat: Add "deno doc" subcommand (denoland#4500) Update to Prettier 2 and use ES Private Fields (denoland#4498) upgrade: dprint 0.9.6 (denoland#4509) upgrade: rusty_v8 to v0.3.9 (denoland#4505) feat: Support Inspector / Chrome Devtools (denoland#4484) Improve isatty and kill API docs; Deno.kill() - throw on Windows (denoland#4497) refactor: rename ConsoleOptions to InspectOptions (denoland#4493) upgrade: dprint 0.9.5 (denoland#4491) feat: window.close() (denoland#4474) errors: replace .lines with explicit .split newline (denoland#4483) doc: improve various API docs and include examples (denoland#4486) hide source line if error message longer than 150 chars (denoland#4487) fix: add fsEvent notify::Error casts (denoland#4488)
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 21, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3980
This PR provides an update to Prettier 2 which unblocks the ability to utilise ES private fields (instead of TypeScript
private). This update also contains a lot of updates to some types which align better to current versions of TypeScript. In particular lots of edits ofdom_types.tsto align tolib.dom.d.ts.There were two areas that got too complex to clean up at the moment:
Both of these areas, while great code contributions, don't align well to existing conventions in the internal of Deno and, in my opinion, should be restructured. In particular the ways they hide information (Events used a bit of private and a bit of symbols but leaks these implementations into the type library, and wasn't consistent while Streams uses symbols which need to convert to ES private, but it also uses a really strange form of "abstract" classes
declare classwhich makes lots of things hard to unpick and the types aren't well aligned to what is inlib.dom.d.tswhich also makes it hard to have fully complaint streams). I will open two other issues related to these.