Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DENO_BUILD_MODE and DENO_BUILD_PATH #4431

Merged
merged 4 commits into from
Mar 21, 2020
Merged

Conversation

ry
Copy link
Member

@ry ry commented Mar 19, 2020

Also remove outdated docs related to ninja/gn.

ry added 2 commits March 19, 2020 13:43
Also remove outdated docs related to ninja/gn.
@ry ry requested a review from piscisaureus March 19, 2020 19:35
tools/util.py Outdated Show resolved Hide resolved
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 2 minor suggestions to reduce configuration overgrowth. Other than that, LGTM.

@ry ry merged commit 0adc86f into denoland:master Mar 21, 2020
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
* Remove DENO_BUILD_MODE and DENO_BUILD_PATH

Also remove outdated docs related to ninja/gn.

* fix

* remove parameter to build_mode()

* remove arg parsing from benchmark.py
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
* Remove DENO_BUILD_MODE and DENO_BUILD_PATH

Also remove outdated docs related to ninja/gn.

* fix

* remove parameter to build_mode()

* remove arg parsing from benchmark.py
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
* Remove DENO_BUILD_MODE and DENO_BUILD_PATH

Also remove outdated docs related to ninja/gn.

* fix

* remove parameter to build_mode()

* remove arg parsing from benchmark.py
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
* Remove DENO_BUILD_MODE and DENO_BUILD_PATH

Also remove outdated docs related to ninja/gn.

* fix

* remove parameter to build_mode()

* remove arg parsing from benchmark.py
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
* Remove DENO_BUILD_MODE and DENO_BUILD_PATH

Also remove outdated docs related to ninja/gn.

* fix

* remove parameter to build_mode()

* remove arg parsing from benchmark.py
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
* Remove DENO_BUILD_MODE and DENO_BUILD_PATH

Also remove outdated docs related to ninja/gn.

* fix

* remove parameter to build_mode()

* remove arg parsing from benchmark.py
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
* Remove DENO_BUILD_MODE and DENO_BUILD_PATH

Also remove outdated docs related to ninja/gn.

* fix

* remove parameter to build_mode()

* remove arg parsing from benchmark.py
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
* Remove DENO_BUILD_MODE and DENO_BUILD_PATH

Also remove outdated docs related to ninja/gn.

* fix

* remove parameter to build_mode()

* remove arg parsing from benchmark.py
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
* Remove DENO_BUILD_MODE and DENO_BUILD_PATH

Also remove outdated docs related to ninja/gn.

* fix

* remove parameter to build_mode()

* remove arg parsing from benchmark.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants