Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Optimize TextEncoder and TextDecoder #4430

Merged
merged 4 commits into from
Mar 19, 2020
Merged

perf: Optimize TextEncoder and TextDecoder #4430

merged 4 commits into from
Mar 19, 2020

Conversation

bartlomieju
Copy link
Member

This PR optimizes TextEncoder and TextDecoder by using Deno.core.encode and Deno.core.decode respectively (when applicable).

@bartlomieju bartlomieju changed the title perf: Optimize TextEncode and TextDecoder perf: Optimize TextEncoder and TextDecoder Mar 19, 2020
@bartlomieju bartlomieju requested a review from ry March 19, 2020 15:59
ry
ry reviewed Mar 19, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the benchmarks, do we still need to run all 4 different encoding ones? Or can we reduce it back to the original two?

ry
ry approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 87d2ba4 into denoland:master Mar 19, 2020
@bartlomieju bartlomieju deleted the text_encoder_uses_Core branch March 19, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bartlomieju @ry