Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace abbreviate object form with line breaking #4425

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

mhvsa
Copy link
Contributor

@mhvsa mhvsa commented Mar 18, 2020

Related with #3165

Previously

{ a: 2, o: { a, b, c, d, e, f, g, asd, asda, x } }

After

{
 a: 2,
 o: {
  a: "1",
  b: "2",
  c: "3",
  d: "4",
  e: "5",
  f: "6",
  g: 10,
  asd: 2,
  asda: 3,
  x: { a: "asd", x: 3 }
 }
}

Node.js

{
  a: 2,
  o: {
    a: '1',
    b: '2',
    c: '3',
    d: '4',
    e: '5',
    f: '6',
    g: 10,
    asd: 2,
    asda: 3,
    x: { a: 'asd', x: 3 }
  }
}

@mhvsa mhvsa force-pushed the object_abbreviate_form branch 2 times, most recently from 1f1f7f3 to c8a2d31 Compare March 22, 2020 18:53
@mhvsa mhvsa changed the title [WIP] Object abbreviate form means each entry starts in new line [WIP] Replace abbreviate object form with line breaking Mar 22, 2020
@hayd
Copy link
Contributor

hayd commented Mar 22, 2020

Can you add a test case?

@mhvsa
Copy link
Contributor Author

mhvsa commented Mar 22, 2020

@hayd sure

@mhvsa mhvsa changed the title [WIP] Replace abbreviate object form with line breaking Replace abbreviate object form with line breaking Mar 22, 2020
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for giving the stringify code some love @mhvsa !

@ry ry merged commit 2e5e5fe into denoland:master Mar 24, 2020
@mhvsa mhvsa deleted the object_abbreviate_form branch March 30, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants