Source map prerequisites #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a dependency of js/v8_source_maps.ts.
Switch the order of the snapshot_creator args, in order to allow for optional source map arg.
Switches to using asm incbin to embed the V8 snapshot instead of outputing C code and then compiling it. Compile time for from_snapshot.o goes from 44s to 1s.
Merged
piscisaureus
reviewed
Aug 1, 2018
| v8::Isolate* isolate = context->GetIsolate(); | ||
| Deno* d = FromIsolate(isolate); | ||
| std::string exception_str; | ||
| HandleExceptionStr(context, exception, &exception_str); |
There was a problem hiding this comment.
Passing a pointer to std::string seems rather un-idiomatic. But whatever.
There was a problem hiding this comment.
Yeah - that's a programmer error - but I will fix it later to avoid having to rebase a bunch of branches :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.