Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reorg: remove dispatch.ts, move signals, factor out web utils #4316

Merged
merged 5 commits into from
Mar 11, 2020
Merged

reorg: remove dispatch.ts, move signals, factor out web utils #4316

merged 5 commits into from
Mar 11, 2020

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Mar 11, 2020 •
edited
Loading

This PR:

  • moves signal definition from "cli/js/process.ts" to "cli/js/signals.ts"
  • removes "cli/js/dispatch.ts"
  • removes "cli/js/types.ts"
  • moves web specific utilities to "cli/js/web/util.ts"

Ref #4248

@bartlomieju bartlomieju mentioned this pull request Mar 11, 2020
Closed
@bartlomieju bartlomieju requested a review from ry March 11, 2020 13:16
@bartlomieju bartlomieju changed the title reorg: remove dispatch.ts, move signals, factor our web utils reorg: remove dispatch.ts, move signals, factor out web utils Mar 11, 2020
ry
ry approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 2d1b39b into denoland:master Mar 11, 2020
@bartlomieju bartlomieju deleted the reorg_cli_js branch March 11, 2020 14:49
dubiousjim added a commit to dubiousjim/deno that referenced this pull request Mar 13, 2020
@dubiousjim
Merge remote-tracking branch 'denoland/master' into filesystem8g
af428e8 
* denoland/master:
  Remove doc strings from cli/js TS files (denoland#4329)
  upgrade: Rust 1.42.0 (denoland#4331)
  Enable std tests in debug mode (denoland#4332)
  fix: Node polyfill fsAppend rework (denoland#4322)
  v0.36.0
  Add waker to StreamResource to fix hang on close bugs (denoland#4293)
  reorg: Deno global initialization (denoland#4317)
  move compiler API tests to integration tests (denoland#4319)
  support permission mode in mkdir (denoland#4286)
  Stricter permissions for Deno.makeTemp* (denoland#4318)
  reorg: remove dispatch.ts, move signals, factor out web utils (denoland#4316)
  reorg: cli/js/compiler/, move more API to cli/js/web/ (denoland#4310)
  Improve dprint config (denoland#4314)
  doc(cli/flags): Reduce empty lines in help messages (denoland#4312)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bartlomieju @ry