refactor: rename structures related to Modules #4217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
reviewed
Mar 2, 2020
| /// Eg. Both "https://example.com/a.ts" and | ||
| /// "https://example.com/b.ts" may point to "https://example.com/c.ts" | ||
| /// By keeping track of specified and found URL we can alias modules and avoid | ||
| /// recompiling the same code 3 times. |
There was a problem hiding this comment.
Don't know; old comment, PTAL at my TODO comment below
There was a problem hiding this comment.
Having some bookkeeping of redirects sounds useful.
bartlomieju
added a commit
to bartlomieju/deno
that referenced
this pull request
Mar 3, 2020
* rename structures related to ES Modules; add "Modules" prefix * remove unneeded Unpin trait requirement for "ModuleLoader"
mhvsa
pushed a commit
to mhvsa/deno
that referenced
this pull request
Mar 6, 2020
* rename structures related to ES Modules; add "Modules" prefix * remove unneeded Unpin trait requirement for "ModuleLoader"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unpintrait requirement for "ModuleLoader"