Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add ResourceTable tests #4185

Merged
merged 1 commit into from
Feb 29, 2020
Merged

Conversation

ecyrbe
Copy link
Contributor

@ecyrbe ecyrbe commented Feb 29, 2020

Somewhat related to #4186 if we decide that nothing has to be implemented. Based on previous PR #4079

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - sorry for not landing the random-rid patch. Because of the discussion it made me hesitate. I'm still in favor of it - but let's land this one first. Thank you.

@ry ry merged commit 199fb19 into denoland:master Feb 29, 2020
@ecyrbe
Copy link
Contributor Author

ecyrbe commented Feb 29, 2020

@ry no worries, i jumped into this without setting a proper discussion. i created one for this purpose. take your time to decide, no need to hurry.

@ecyrbe ecyrbe deleted the feature/resources-tests branch March 1, 2020 22:05
mhvsa pushed a commit to mhvsa/deno that referenced this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants