Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: use subarray instead of slice in dispatch minimal #4180

Merged
merged 7 commits into from
Mar 1, 2020
Merged

perf: use subarray instead of slice in dispatch minimal #4180

merged 7 commits into from
Mar 1, 2020

Conversation

ry
Copy link
Member

@ry ry commented Feb 29, 2020

attempt 2 #4173

@ry ry requested a review from piscisaureus February 29, 2020 02:13
@bartlomieju
Copy link
Member

f560617 updates shared queue to transparently align all records to 4 byte words. Problem described in #4173 is now gone.

ry
ry commented Mar 1, 2020
View reviewed changes
core/shared_queue.js Outdated Show resolved Hide resolved
core/shared_queue.rs Outdated Show resolved Hide resolved
core/shared_queue.rs Outdated Show resolved Hide resolved
ry
ry commented Mar 1, 2020
View reviewed changes
core/shared_queue.js Outdated Show resolved Hide resolved
ry
ry commented Mar 1, 2020
View reviewed changes
core/shared_queue.rs Outdated Show resolved Hide resolved
piscisaureus
piscisaureus reviewed Mar 1, 2020
View reviewed changes
core/shared_queue.rs Outdated Show resolved Hide resolved
piscisaureus
piscisaureus approved these changes Mar 1, 2020
View reviewed changes
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 1 comment.

@ry ry merged commit ad21210 into denoland:master Mar 1, 2020
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Mar 3, 2020
@ry @bartlomieju
perf: use subarray instead of slice in dispatch minimal (denoland#4180)
ba6e312
mhvsa pushed a commit to mhvsa/deno that referenced this pull request Mar 6, 2020
@ry @mhvsa
perf: use subarray instead of slice in dispatch minimal (denoland#4180)
70c7c70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piscisaureus piscisaureus piscisaureus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ry @bartlomieju @piscisaureus