Remove msg_generated hack #409
Conversation
tsconfig.json
Outdated
| "experimentalDecorators": true | ||
| "experimentalDecorators": true, | ||
| "paths": { | ||
| "*": [ "*", "out/debug/gen/*", "out/default/gen/*", "out/release/gen/*" ] |
There was a problem hiding this comment.
The build path isn't guaranteed to look like these. On travis, for example, we use $HOME/out/Default (capitalization intentional)
I suppose this is what's causing travis to fail. Try building with ./tools/build.py --build_path=/tmp/deno_build to debug. Can we somehow tell TS to just ignore msg_generated ?
There was a problem hiding this comment.
The problem with "ignoring" it is that it is hacky and also stop TypeScript from ensuring that it is used type safe, which seems contrary to the whole thing.
What I could do, is keep this for design time editors, but in the rollup.config.js is dynamically use the build path when compiling the bundle. Not sure why I didn't think of that first.
rollup.config.js
Outdated
| resolveId(importee) { | ||
| if (importee === "msg_generated") { | ||
| return path.resolve( | ||
| path.join(process.cwd(), "gen", "msg_generated.ts") |
There was a problem hiding this comment.
This works. It's a little hacky to hardcode "gen/msg_generated.ts" but much better than what we previously had. Consider adding a comment about how this path could change if BUILD.gn was updated...
There was a problem hiding this comment.
Valid point. This may not be the only generated asset that ends up in the bundle, so I should change it to be a more generic too. So that any MID that starts with gen/* gets remapped to the current build directory.
| ":msg_ts", | ||
| ] | ||
| } | ||
|
|
|
I think I got everything squared away and it feels a lot more maintainable now, than trading one ugly hack for a less ugly hack. |
Resolves #403
It mostly makes it maintainable. TypeScript still wants to resolve the
msg_generateditself to be type safe. So we had to go away from a relative MID and go to an absolute and then map that absolute to resolve to the generated modules (ergo thepathsin thetsconfig.jsonnow). It also means we have to pick a resolution order. It also means that an editor, like VSCode, will error until at least onemsg_generated.tsis generated.We also had to generate another bit of logic in the
rollup.config.jsto resolve the module at bundle time properly.I think I cleaned up all the hackery.