Added --v8-options replacement #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
reviewed
Jul 25, 2018
src/main.rs
Outdated
| fn test_flag_parse_2() { | ||
| let js_args = set_flags(vec!["deno".to_string(), "--help".to_string()]); | ||
| assert!(js_args == vec!["deno".to_string(), "--help".to_string()]); | ||
| } |
There was a problem hiding this comment.
I'm not so happy with the huge v8 help output during the tests - it makes it hard to see what passed/failed. How about testing parse_core_args instead of set_flags?
ry
approved these changes
Jul 25, 2018
src/main.rs
Outdated
| @@ -125,22 +125,23 @@ impl Drop for Deno { | |||
|
|
|||
| #[test] | |||
| fn test_flag_parse_1() { | |||
There was a problem hiding this comment.
please rename to test_parse_core_args_1
src/main.rs
Outdated
| assert!(js_args == vec!["deno".to_string()]); | ||
| let js_args = | ||
| parse_core_args(vec!["deno".to_string(), "--v8-options".to_string()]); | ||
| assert!(js_args == (vec!["deno".to_string(), "--help".to_string()], vec![])); | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_flag_parse_2() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/ry/deno/issues/376