-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stack traces for required modules #4035
Conversation
@seishun Hey thanks - looks fine to me. But would you be able to add a test that shows the new output? Follow the example of 001_hello.js in cli/tests/integration_tests.rs |
Is cli/tests/integration_tests.rs the right place for a test for an std module? |
@seishun I guess the test could use std... but ideally it will be just a small standalone script. It just needs to generate the stack trace that has been changed. So it should fail on master and be green here. |
Added a test. |
I can't reproduce the test failure locally. Seems unrelated. |
@seishun can you rebase this PR to latest master? |
@bartlomieju I've rebased it, but it seems it wasn't necessary (no conflicts). |
I have checked that the test fails before the change. I'm +1 on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@seishun thanks! |
Before:
After:
I'm quite new to Rust, so any suggestions on the code will be greatly appreciated.