Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with detecting AMD like imports #4009

Merged
merged 1 commit into from
Feb 16, 2020

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Feb 16, 2020

Fixes the issue mentioned in #3089 (comment). Essentially when we were preprocessing the dependencies, we were looking for JavaScript like dependencies, which include things like AMD and others. Only detecting these when the media type is JS (which implies that checkJs is enabled and we could be transpiling AMD/CommonJS/etc to ESM) should eliminate improper detection.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinkassimo
Copy link
Contributor

This actually was one of the issues I had with require() polyfill in std/node before, that I have to call the function require_(). I guess now we can finally update the docs to normal require()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants