refactor: cleanup cli/lib.rs #4006

bartlomieju · 2020-02-15T17:42:47Z

rename Worker methods related to modules
remove cli/progress.rs, remove cli/shell.rs

ry · 2020-02-18T14:52:52Z

cli/worker.rs

 &mut self,
 module_specifier: &ModuleSpecifier,
- maybe_code: Option<String>,
- is_prefetch: bool,


ry

LGTM - good clean up

bartlomieju added 4 commits February 15, 2020 17:04

refactor worker.execute_mod_async

7ff9469

lint

8ddcb1d

reorganize cli/lib.rs

5b5da83

reorganize cli/lib.rs, part 2

f20f5e5

bartlomieju changed the title ~~[WIP] refactor: lib.rs~~ refactor: cli/lib.rs and Worker module API Feb 16, 2020

bartlomieju added 3 commits February 18, 2020 01:26

dont use progress

fbd87a7

remove progress.rs and shell.rs

eccf2f4

Merge branch 'master' into refactor_lib_rs

0f67089

bartlomieju changed the title ~~refactor: cli/lib.rs and Worker module API~~ refactor: cleanup cli/lib.rs Feb 18, 2020

match cargo color

8322dc9

ry reviewed Feb 18, 2020

View reviewed changes

cli/worker.rs

&mut self,

module_specifier: &ModuleSpecifier,

maybe_code: Option<String>,

is_prefetch: bool,

Copy link

Member

ry Feb 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ry approved these changes Feb 18, 2020

View reviewed changes

bartlomieju merged commit 302debe into denoland:master Feb 18, 2020

bartlomieju deleted the refactor_lib_rs branch February 18, 2020 15:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: cleanup cli/lib.rs #4006

refactor: cleanup cli/lib.rs #4006

bartlomieju commented Feb 15, 2020 •

edited

Loading

ry Feb 18, 2020

ry left a comment

refactor: cleanup cli/lib.rs #4006

refactor: cleanup cli/lib.rs #4006

Conversation

bartlomieju commented Feb 15, 2020 • edited Loading

ry Feb 18, 2020

Choose a reason for hiding this comment

ry left a comment

Choose a reason for hiding this comment

bartlomieju commented Feb 15, 2020 •

edited

Loading