Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace Arc<Box<..>> with Rc<..> #3996

Merged
merged 3 commits into from
Feb 15, 2020
Merged

refactor: replace Arc<Box<..>> with Rc<..> #3996

merged 3 commits into from
Feb 15, 2020

Conversation

bartlomieju
Copy link
Member

No description provided.

@bartlomieju bartlomieju requested a review from ry February 14, 2020 09:10
ry
ry reviewed Feb 14, 2020
View reviewed changes
core/es_isolate.rs Outdated Show resolved Hide resolved
@bartlomieju bartlomieju changed the title refactor: remove Arc<Box<..>> refactor: replace Arc<Box<..>> with Rc<..> Feb 14, 2020
ry
ry approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit a0f015b into denoland:master Feb 15, 2020
@bartlomieju bartlomieju deleted the remove_arc_boxes branch February 15, 2020 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

@gil0mendes gil0mendes gil0mendes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bartlomieju @ry @gil0mendes