Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correctly determine a --cached-only error #3979

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

nayeemrmn
Copy link
Collaborator

https://gitter.im/denolife/Lobby?at=5e4375e219597421f3c33fef.

No longer get a --cached-only error message for any cache permission error. Also use NotFound for --cached-only errors.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm refactoring file fetcher now so it will probably evolve a bit more down the road

@bartlomieju bartlomieju merged commit 3563ab4 into denoland:master Feb 12, 2020
@nayeemrmn nayeemrmn deleted the cached-only-error branch February 12, 2020 16:31
geoFlux added a commit to geoFlux/deno that referenced this pull request Feb 14, 2020
* master:
  v0.33.0
  fix: appended CRLF to end of trailer headers (denoland#3989)
  Clean up fmt flags and path handling (denoland#3988)
  Improvements to bundling. (denoland#3965)
  fix: Correctly determine a --cached-only error (denoland#3979)
  chore: share HTTP server between tests (denoland#3966)
  dont use env vars in multiple installer tests (denoland#3967)
  feat(node): add EventEmitter.errorMonitor (denoland#3960)
  fix(file_server): don't crash on "%" pathname (denoland#3953)
  update references to testing/mod.ts in manual (denoland#3973)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants