Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rewrite tests in std/ to use Deno.test #3930

Merged
merged 28 commits into from
Feb 11, 2020

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Feb 8, 2020

  • rewrite all tests in "std/" to use "Deno.test()"
  • remove "std/testing/mod.ts"

@bartlomieju bartlomieju changed the title [WIP] rewrite tests in std/ to use Deno.test refactor: rewrite tests in std/ to use Deno.test Feb 11, 2020
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I love these big numbers of lines removed.

Please be extra sure this isn't silently breaking tests in std and cli/js. (If you change an assert there they should still break cargo test)

@bartlomieju
Copy link
Member Author

LGTM - I love these big numbers of lines removed.

Please be extra sure this isn't silently breaking tests in std and cli/js. (If you change an assert there they should still break cargo test)

Confirmed, that adding failing assertion breaks cargo test

@bartlomieju bartlomieju merged commit 6127308 into denoland:master Feb 11, 2020
@bartlomieju bartlomieju deleted the tests_std branch February 11, 2020 16:24
@tkgalk
Copy link
Contributor

tkgalk commented Feb 11, 2020

I asked about it on Gitter too (once I get an answer there I'll leave it here for posterity as well) but this change broke my CI. https://github.com/galkowskit/denofun/pull/43/checks?check_run_id=439140417

It looks like removal of mod.ts wasn't an issue for local tests (cached?) but it 404'd on CI. I need to update my tests to Deno.test, that's for sure.

But what would be the recommended approach for community to lock dependencies and update them later? import { assertEquals, test } from "https://deno.land/std/testing/mod.ts@<commit-hash>"? Would that even work for removed files?

@bartlomieju
Copy link
Member Author

@galkowskit

import { assertEquals, test } from "https://deno.land/[email protected]/testing/mod.ts

@nayeemrmn
Copy link
Collaborator

nayeemrmn commented Feb 11, 2020

There are some references to std/testing/mod.ts in the manual and the README.

caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants