Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deno.makeTempDir() check permissions #3810

Merged
merged 2 commits into from
Jan 30, 2020
Merged

Conversation

manyuanrong
Copy link
Contributor

closes #3729

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but can you add a unit test to cli/js/make_temp_dir_test.ts which checks permission? There are permission checking examples in that folder for other FS methods.

(To run the tests: cargo test unit_test)

@manyuanrong
Copy link
Contributor Author

@ry There are already test cases for perm in make_temp_dir_test.ts. Like makeDir and readFile, only the permission switch flag is tested. There is no whitelist of test permissions.

@ry
Copy link
Member

ry commented Jan 30, 2020

@manyuanrong Ah - I see. Hmm. We need some way to test whitelist permissions, but let's just land your PR now. We can kick that can down the road. Thank you.

@ry ry merged commit 1c6c6c6 into denoland:master Jan 30, 2020
@manyuanrong manyuanrong deleted the fix_mk_temp_dir branch January 30, 2020 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deno.makeTempDir() doesn't check permissions
2 participants