Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make eval support --v8-flags=... #3797

Merged
merged 1 commit into from
Jan 26, 2020
Merged

feat: make eval support --v8-flags=... #3797

merged 1 commit into from
Jan 26, 2020

Conversation

bnoordhuis
Copy link
Contributor

Closes #3796

ry
ry approved these changes Jan 26, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cli/tests/integration_tests.rs
itest!(eval_v8_flags {
args: "eval --v8-flags=--expose-gc console.log(typeof(gc))",
output: "v8_flags.js.out",
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

itest! splits args on whitespace.

Oops - I suppose we should have another one that takes a vec.

@ry ry merged commit 97ed0c9 into denoland:master Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deno eval does not support --v8-flags=
2 participants
@bnoordhuis @ry