Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: take control buffer offset/length into account again #3769

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Fix: take control buffer offset/length into account again #3769

merged 1 commit into from
Jan 24, 2020

Conversation

piscisaureus
Copy link
Member

No description provided.

@piscisaureus piscisaureus requested a review from ry January 24, 2020 03:58
ry
ry approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no tests failed without this? that's disconcerting.

Seem like we need something like impl From<&[u8]> for ArrayBufferView to avoid this repeated code.

@piscisaureus
Copy link
Member Author

Seem like we need something like impl From<&[u8]> for ArrayBufferView to avoid this repeated code.

Not against it, but due to the shared nature of the backing store buffer it'd still need to be wrapped in an UnsafeCell.

@piscisaureus piscisaureus merged commit a6a7253 into denoland:master Jan 24, 2020
@piscisaureus piscisaureus deleted the fix_control_offset branch February 28, 2020 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@piscisaureus @ry