Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade rusty_v8 to 0.2.0 #3764

Merged
merged 2 commits into from
Jan 24, 2020
Merged

Upgrade rusty_v8 to 0.2.0 #3764

merged 2 commits into from
Jan 24, 2020

Conversation

ry
Copy link
Member

@ry ry commented Jan 23, 2020

No description provided.

@ry ry requested a review from piscisaureus January 23, 2020 17:14
piscisaureus
piscisaureus reviewed Jan 23, 2020
View reviewed changes
core/bindings.rs Outdated Show resolved Hide resolved
piscisaureus
piscisaureus reviewed Jan 23, 2020
View reviewed changes
core/isolate.rs Outdated Show resolved Hide resolved
piscisaureus
piscisaureus approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, because I have to leave.
There's a transmute in bytes_mut() that can also be removed if you have the time.

@ry
Copy link
Member Author

ry commented Jan 23, 2020

There's a transmute in bytes_mut() that can also be removed if you have the time.

I don't know which transmute you mean. There don't seem to be any in core anymore.

It seems there's a problem with the windows build - can you repeat the failure?

@ry ry merged commit 9f1e423 into denoland:master Jan 24, 2020
@ry ry deleted the upgrade_rusty_v8 branch January 24, 2020 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piscisaureus piscisaureus piscisaureus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ry @piscisaureus