refactor: remove Isolate.shared_response_buf #3759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
reviewed
Jan 23, 2020
ry
approved these changes
Jan 23, 2020
There was a problem hiding this comment.
@bartlomieju LGTM - this is a very very nice clean up - thank you! I'm so glad to be rid of these complex pseudo optimizations.
I would have expected a speed improvement in isolate::tests::overflow_res_sync (and the other overflow tests), but that doesn't seem to have happened. I don't understand this. Nevertheless, I think you've successfully made it so that the return buffers from ops are zero-copy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
Isolate.shared_response_buf.Currently we have a pretty complex situation when responding from Rust to V8 when shared queue overflows, covered by those three cases:
a) response is bigger than
shared_response_buf(1Mb) - create newArrayBufferb)
shared_response_bufhas not been instantiated - lazy instantiate itc) response fits into
shared_response_buf- use itInstead I rewrote this situation to always transfer memory from Rust to V8, ie. always create new
ArrayBufferand set it's backing store to underlying Rust-allocated memory.