Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix deno_core_http_bench #3698

Merged
merged 1 commit into from
Jan 17, 2020
Merged

fix deno_core_http_bench #3698

merged 1 commit into from
Jan 17, 2020

Conversation

bartlomieju
Copy link
Member

No description provided.

@bartlomieju bartlomieju requested a review from ry January 17, 2020 13:57
ry
ry approved these changes Jan 17, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really need some unit tests on this thing so we catch it before it gets to the benchmarks. But let's just land this.

LGTM

@bartlomieju bartlomieju merged commit d776ca8 into denoland:master Jan 17, 2020
@bartlomieju bartlomieju deleted the fix_deno_core_http_bench branch January 17, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bartlomieju @ry