Revert "feat(flags): script arguments come after '--' (#3621)" #3681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to complaints about ergonomics and because it breaks shebang on linux. This reverts commit 2d5457d.
|
Shebangs work just as well on GNU coreutils 8.30+, for before that there is no way of setting interpreter flags on Linux. In other words this didn't break anything any more than the need for a permission flag does -- Linux shebangs are broken (except for GNU coreutils 8.30+) either way. The following applies to all platforms: The other ergonomic problem is described here #3621 (comment) and a solution is given here #3621 (comment) but that solution depends on the unfixed bug reported in #3011, which was wrongly closed. ... In other words, +1 for reverting and reopening #3011! |
bartlomieju
approved these changes
Jan 16, 2020
serverhiccups
pushed a commit
to serverhiccups/deno
that referenced
this pull request
Jan 16, 2020
Due to complaints about ergonomics and because it breaks shebang on linux. This reverts commit 2d5457d. BREAKING CHANGE
Alhadis
added a commit
to Alhadis/EAL
that referenced
this pull request
Jan 19, 2020
bartlomieju
pushed a commit
to bartlomieju/deno
that referenced
this pull request
Jan 21, 2020
Due to complaints about ergonomics and because it breaks shebang on linux. This reverts commit 2d5457d. BREAKING CHANGE
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to complaints about ergonomics and because it breaks shebang on
linux.
This reverts commit 2d5457d.