Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workers: minimal error handling and async module loading #3665

Merged
merged 18 commits into from
Jan 17, 2020
Merged

workers: minimal error handling and async module loading #3665

merged 18 commits into from
Jan 17, 2020

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Jan 12, 2020 •
edited
Loading

Fixes #2444
Fixes #3020

@bartlomieju bartlomieju mentioned this pull request Jan 13, 2020
Closed
@bartlomieju bartlomieju changed the title [WIP] workers: Basic error handling workers: Error handling and async module loading Jan 13, 2020
@bartlomieju bartlomieju changed the title workers: Error handling and async module loading [WIP] workers: Error handling and async module loading Jan 13, 2020
@bartlomieju bartlomieju changed the title [WIP] workers: Error handling and async module loading workers: minimal error handling and async module loading Jan 17, 2020
@bartlomieju bartlomieju requested a review from ry January 17, 2020 12:29
@bartlomieju
Copy link
Member Author

@ry not fully done, but it's landable now. Runtime snapshot blocks further work for now

ry
ry reviewed Jan 17, 2020
View reviewed changes
core/es_isolate.rs Outdated Show resolved Hide resolved
ry
ry approved these changes Jan 17, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but consider moving that method to core/isolate.rs

@ry ry merged commit 5fa056e into denoland:master Jan 17, 2020
@bartlomieju bartlomieju deleted the workers branch January 18, 2020 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uncaught errors in workers should trigger onerror Workers crash silently
2 participants
@bartlomieju @ry