Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove Isolate.current_send_cb_info and DenoBuf, port Isolate.shared_response_buf #3643

Merged
merged 12 commits into from
Jan 11, 2020
Merged

refactor: remove Isolate.current_send_cb_info and DenoBuf, port Isolate.shared_response_buf #3643

merged 12 commits into from
Jan 11, 2020

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Jan 9, 2020 •
edited
Loading

This PR:

  • removes Isolate.current_send_cb_info
  • removes DenoBuf
  • removes Isolate.shared_ab
  • port Isolate.shared_response_buf (last bit not ported from libdeno)
  • adds some docs for Isolate and EsIsolate

@bartlomieju bartlomieju changed the title [WIP] refactor: remove Isolate.current_send_cb_info refactor: remove Isolate.current_send_cb_info Jan 10, 2020
@bartlomieju bartlomieju mentioned this pull request Jan 10, 2020
Closed
@bartlomieju bartlomieju changed the title refactor: remove Isolate.current_send_cb_info refactor: remove Isolate.current_send_cb_info and DenoBuf Jan 10, 2020
@bartlomieju bartlomieju changed the title refactor: remove Isolate.current_send_cb_info and DenoBuf refactor: remove Isolate.current_send_cb_info and DenoBuf, port Isolate.shared_response_buf Jan 10, 2020
ry
ry approved these changes Jan 11, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

core/es_isolate.rs
/// Tokio. The Isolate future complete when there is an error or when all
/// pending ops have completed.
/// More specialized version of `Isolate` that provides loading
/// and execution of ES Modules.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bartlomieju bartlomieju merged commit 0d0ad36 into denoland:master Jan 11, 2020
@bartlomieju bartlomieju deleted the refactor_deno_send branch January 11, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

@piscisaureus piscisaureus Awaiting requested review from piscisaureus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bartlomieju @ry