Remove -f option from rustfmt. #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tools/format.py
Outdated
| @@ -19,4 +19,4 @@ | |||
| run(["yapf", "-i"] + glob("tools/*.py")) | |||
| run(["node", prettier, "--write"] + glob("js/*.js") + glob("js/*.ts") + | |||
| ["tsconfig.json"] + ["tslint.json"]) | |||
| run(["rustfmt", "-f", "--write-mode", "overwrite"] + glob("src/*.rs")) | |||
| run(["rustfmt", "--write-mode", "overwrite"] + glob("src/*.rs")) | |||
There was a problem hiding this comment.
This breaks it for me again, I can't figure out how to get rustfmt to work without switching to the nightly toolchain.
They appear to try very hard to make it impossible.
Maybe pick up RUSTFMT_FLAGS from the environment so I can use that?
There was a problem hiding this comment.
It looks like you should already be able to use RUSTFMT_FLAGS
https://github.com/ry/deno/blob/d160de7f445e5d79883f2e8d97584b8afd009cc7/tools/util.py#L7-L13
There was a problem hiding this comment.
Ah, sorry, I thought you meant that RUSTFMT_FLAGS was an already recognized option... I added another commit that does as you asked
piscisaureus
pushed a commit
to piscisaureus/deno
that referenced
this pull request
Oct 7, 2019
Make warnings fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.